Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace for exporters #1770

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Fix namespace for exporters #1770

merged 3 commits into from
Feb 2, 2021

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Feb 2, 2021 •
edited by cijothomas
Loading

This PR makes the namespace used by exporters consistent.

All the exporter and the respective options classes will now be under OpenTelemetry.Exporter namespace.

Continuation of #1332
Related: #1766

Changes

  • Updated the namespace of exporters and exporter options to OpenTelemetry.Exporter

@utpilla utpilla requested a review from a team February 2, 2021 00:04
@codecov
Copy link

codecov bot commented Feb 2, 2021 •
edited
Loading

Codecov Report

Merging #1770 (94f4b90) into main (56b86b0) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
+ Coverage   84.11%   84.21%   +0.10%     
==========================================
  Files         187      187              
  Lines        5923     5923              
==========================================
+ Hits         4982     4988       +6     
+ Misses        941      935       -6
Impacted Files Coverage Δ
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 83.33% <ø> (ø)
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 15.38% <ø> (ø)
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <ø> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <ø> (ø)
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 57.44% <ø> (ø)
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 92.30% <ø> (ø)
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 87.50% <ø> (ø)
....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs 15.38% <ø> (ø)
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <ø> (ø)
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 74.11% <0.00%> (+2.35%) ⬆️
... and 2 more

cijothomas
cijothomas approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entries needed

@cijothomas cijothomas merged commit e438998 into open-telemetry:main Feb 2, 2021
@cijothomas
Copy link
Member

Merging as this is the last opportunity to make this change before 1.0.
This is breaking for RC1,2 users, which is acceptable.
Most users use extension method AddConsole, AddJaeger etc, which uses Otel.Trace namespace, and is not changed in this PR.

@utpilla utpilla deleted the utpilla/Fix-Namespace-For-Exporters branch February 10, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utpilla @cijothomas